Fix getElementBoundingBox() OOP version returning 6 numbers instead of a 2 vectors #305
Conversation
|
Also, please see the header file, I left a comment there, please help me out with that :) |
| @@ -42,6 +42,7 @@ class CLuaElementDefs : public CLuaDefs | |||
| LUA_DECLARE(GetElementDimension); | |||
| LUA_DECLARE(GetElementZoneName); | |||
| LUA_DECLARE(GetElementBoundingBox); | |||
| LUA_DECLARE_OOP(GetElementBoundingBox);// Probably wrong, tell me how to declare the OOP version of this. | |||
There was a problem hiding this comment.
This is ok. You should remove LUA_DECLARE(GetElementBoundingBox) as LUA_DECLARE_OOP(GetElementBoundingBox) automatically does both. This duplicate declaration causes a compile error C2535.
There was a problem hiding this comment.
Thanks, I'll remove it.
| @@ -42,7 +42,6 @@ class CLuaElementDefs : public CLuaDefs | |||
| LUA_DECLARE(GetElementDimension); | |||
| LUA_DECLARE(GetElementZoneName); | |||
| LUA_DECLARE(GetElementBoundingBox); | |||
| LUA_DECLARE_OOP(GetElementBoundingBox);// Probably wrong, tell me how to declare the OOP version of this. | |||
There was a problem hiding this comment.
No, you did it the other way around :)
Remove LUA_DECLARE(GetElementBoundingBox), keep LUA_DECLARE_OOP(GetElementBoundingBox).
For your reference, this is how they work:
#define LUA_DECLARE(x) static int x ( lua_State * luaVM );
#define LUA_DECLARE_OOP(x) LUA_DECLARE(x) LUA_DECLARE(OOP_##x)There was a problem hiding this comment.
Ahh, alright, thanks :)
|
I think the 510990e (min_mta_version tag in meta) solution is more elegant than a bool argument for legacy style |
|
Reminder for committer: |
|
Thank you! |
Small'n'Easy to test.
Fixes the OOP version of getElementBoudingBox.